Skip to content
This repository has been archived by the owner on Jun 2, 2018. It is now read-only.

Support iOS6 SDK? #199

Closed
alexburkhay opened this issue Dec 2, 2013 · 8 comments
Closed

Support iOS6 SDK? #199

alexburkhay opened this issue Dec 2, 2013 · 8 comments

Comments

@alexburkhay
Copy link

NSFoundationVersionNumber10_8 is not defined in iOS6 SDK (so build fails), some applications still need to be built under this sdk for iOS7. BlocksKit supports iOS6 SDK ?
Thanks.
P.S. i use cocoapods

@zwaldowski
Copy link
Collaborator

We extremely, extremely strongly recommend compiling against the 7.0 SDK and deploying back to 6.0, to the point that I consider not supporting any other way. However, if it's a matter of adding the define ourselves, we will do so in time for BlocksKit 2.1.

@alexburkhay
Copy link
Author

"We extremely, extremely strongly recommend compiling against the 7.0 SDK and deploying back to 6.0" - there are long term apps for which neither time nor money to upgrade against iOS7 SDK (ui problems etc.)
"if it's a matter of adding the define ourselves, we will do so in time for BlocksKit 2.1."
I'd appreciate that. I'll stick to 1.8.3 until, no rush;) It's also fine if you don't want to add this support fix.

@zwaldowski zwaldowski reopened this Dec 2, 2013
@dwery
Copy link

dwery commented Dec 3, 2013

it seems that TARGET_OS_MAC is also defined when building for the iPhone. If so, this conditional test is wrong.

#if TARGET_OS_MAC
        shouldStrip = (floor(NSFoundationVersionNumber) < NSFoundationVersionNumber10_8);
#elif TARGET_OS_IPHONE
        shouldStrip = (floor(NSFoundationVersionNumber) < NSFoundationVersionNumber_iOS_6_0);
#else
        shouldStrip = YES;
#endif

@alexburkhay
Copy link
Author

dwery, you are right. I missed this issue - checking #if TARGET_OS_MAC is wrong because it always returns true for Mac and iPhone. Thats why build fails on string
shouldStrip = (floor(NSFoundationVersionNumber) < NSFoundationVersionNumber10_8);
and not on
shouldStrip = (floor(NSFoundationVersionNumber) < NSFoundationVersionNumber_iOS_6_0); where it should

@alexburkhay
Copy link
Author

TARGET_OS_IPHONE is 0 when building a Mac application. First #if TARGET_OS_IPHONE should be checked

@zwaldowski
Copy link
Collaborator

Thanks, gents. I always get caught by that one. Are you guys deploying from the 6.0 SDK back to 5.0, or just 6 to 6?

@dwery
Copy link

dwery commented Dec 3, 2013

6 to 6 actually, with Xcode4 for some older apps. I don't plan to support 5 and will probably drop 6 in a few months as well.

@zwaldowski
Copy link
Collaborator

Okay, interesting. I don't mind supporting the 6.0 SDK, it's no skin off my nose, but supporting 5.0 is holding us back from some pretty severe speed improvements with the new Foundation classes. (Not to mention having to do this ugly regex of @encode strings, too.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants