removeObserverWithBlockToken should be removed

[ghost]

[NSObject+BlockObservation removeObserverWithBlockToken:] should be removed not deprecated, because it is not compatible anymore with the [NSObject+BlockObservation addObserverForKeyPath:task:] call. Code that uses this old method will crash on

NSString *identifier = [split objectAtIndex:1];

[zwaldowski]

Yep, fixed! I wasn't paying too much attention to that one. Thanks!

[ghost]

Yep, but now you've also removed - (NSString *)addObserverForKeyPath:(NSString *)keyPath task:(BKObservationBlock)task. That wasn't necessary, I guess. This method simply created an identifier for you instead of making the user create one every time he added an observer. It was quite convenient. I was only stating that it did not work with removeObserverWithBlockToken: since this method expected an internal block token composed of the keyPath and the identifier, but the addObservermethod only returned the identifier.