This repository has been archived by the owner on Jun 2, 2018. It is now read-only.
Fix warnings building with -Warc-bridge-casts-disallowed-in-nonarc #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BlocksKit has not supported being compiled without ARC since the release of the iOS 5 GM SDK in October 2011. |
|
I am using ARC, and BlocksKit (installed via Cocoapods) is as well. Not entirely sure what's going on here. I did disable that compiler flag. Thanks anyway |
|
I'm sorry I couldn't help better. I've never seen that warning in ARC mode, and I'm looking at the Clang's source right now and that warning can't be reached unless it's being parsed in non-ARC mode. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Xcode 4.6.3, building with iOS 6.1 as a target and using
-Warc-bridge-casts-disallowed-in-nonarc, I get several warnings inBKMacros.h:'__bridge' casts have no effect when not using ARC.This pull request just removes those
__bridgecasts so the project builds properly.I haven't tested this on OSX so not sure if there are any other side effects, but it would be nice to build on iOS with stricter settings. Thanks for a great project!