Adding unit tests to BlocksKit

[kaiwu]

Hi,

BlocksKit is nice, i started adding unit test for them, the pull request contains tests for

• NSArray+BlocksKit
• NSDictionary+BlocksKit

Not sure if i spotted a problem, the method below seems to have a problem
- (id)reduce:(id)initial withBlock:(BKAccumulationBlock)block

its returned object is always invalid
i am bypassing it in the test as

NSString *concatenated = [_subject reduce:@"" withBlock:accumlationBlock];
GHAssertEqualStrings(@"122333",@"122333",@"concatenated string is %@",concatenated);

concatenated is invalid, shall i raise an issue ?

[zwaldowski]

I'll look into the issue momentarily, and thank you so much for
starting on that, really great stuff. I'll pull them later today,

Sent from my iPad

On Jul 3, 2011, at 10:02 AM, kaiwu
reply@reply.github.com
wrote:

Hi,

BlocksKit is nice, i started adding unit test for them, the pull request contains tests for

• NSArray+BlocksKit
• NSDictionary+BlocksKit

Not sure if i spotted a problem, the method below seems to have a problem
- (id)reduce:(id)initial withBlock:(BKAccumulationBlock)block

its returned object is always invalid
i am bypassing it in the test as

NSString *concatenated = [_subject reduce:@"" withBlock:accumlationBlock];
GHAssertEqualStrings(@"122333",@"122333",@"concatenated string is %@",concatenated);

concatenated is invalid, shall i raise an issue ?

Reply to this email directly or view it on GitHub:
#6

[zwaldowski]

All right, that part's fixed. If you want to modify your commit to make the test actually test again, I'll merge it immediately.

[kaiwu]

verified the fix with the test, close this pull request with a new one