Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use this lib on ionic 1 project. #8

Open
abdulwahid24 opened this issue Sep 18, 2017 · 3 comments
Open

How to use this lib on ionic 1 project. #8

abdulwahid24 opened this issue Sep 18, 2017 · 3 comments

Comments

@abdulwahid24
Copy link

Hi,

This might seem a silly question but I couldn't understand how can I use this on existing ionic 1 project.

Please do let me know what would be the process.

Thanks

@zxbodya
Copy link
Owner

zxbodya commented Sep 18, 2017

Yes, It can be adopted. Eventually one of the first projects where is was used - was old ionic1 project :)

Migration process is relatively simple - you can start using your existing sources as is, by creating entry module where importing the same files that were included as script tags in html. When building for ionic you will also need to change publicPath for output bundle to be relative, and path for output (in make-webpack-config). Also if you do not have proper DI annotations or working ng-annotate - disable scripts minimization, or fix annotations.

Basically, this should be minimal changes, required to get it working.

next steps, I would suggest when updating project:

  • replace 'templateUrl', by template and directly requiring html file
  • doing eslint --fix and reviewing the results (be careful with this one)

@abdulwahid24
Copy link
Author

Thanks, @zxbodya I would try it as per your instructions and will get back to you.

@masthisis
Copy link

@abdulwahid24 did you get it to work ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants