Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default throttling should be set #24

Closed
csutorasr opened this issue Feb 1, 2018 · 6 comments
Closed

Default throttling should be set #24

csutorasr opened this issue Feb 1, 2018 · 6 comments
Assignees

Comments

@csutorasr
Copy link
Contributor

csutorasr commented Feb 1, 2018

Why change an existing behavior?
The default throttling is now 1500ms. It may differ for applications.

Expected behavior
There should be an providable config object also for the configurations maybe added later.

@odahcam odahcam added this to the v1.0.0 - I see you milestone Feb 1, 2018
@odahcam odahcam self-assigned this Feb 1, 2018
@odahcam
Copy link
Member

odahcam commented Feb 8, 2018

I'm working on it and it seems a little odd, because throttling needs to be set throught the qr reader class instantiation. Things can get a little unperformant if I bind this behavior to an @Input property. We gotta discuss some ideas on how to implement this.

@csutorasr
Copy link
Contributor Author

As I told you it can be injected. I will add the link from the docs later.

@odahcam
Copy link
Member

odahcam commented Feb 8, 2018

If you know how to do, add your snippet here and I will properly add to the project, or make a PR. 😁

@csutorasr
Copy link
Contributor Author

They are called injection tokens. Here is the docs: https://angular.io/guide/dependency-injection#dependency-injection-tokens

If I have time I will make the changes.

@werthdavid
Copy link
Member

Can we close that now?

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants