Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log output #36

Closed
werthdavid opened this issue Feb 26, 2018 · 4 comments
Closed

Remove log output #36

werthdavid opened this issue Feb 26, 2018 · 4 comments

Comments

@werthdavid
Copy link
Member

I'd suggest that we remove the console.log and console.warn output or at least replace it with console.debug (browser-code-reader.ts)

@csutorasr
Copy link
Contributor

Are those needed?

I think all of them could be removed from builds, as they are only used in development of the library. If the library works, no one will use them. If someone would like to debug the library they will pull the repo and see the console.

@odahcam
Copy link
Member

odahcam commented Feb 26, 2018

Please, note that I'm publishing under a v0.0.0-**dev**.<hash> tag, I intend to remove these logs at the final version as well. 😄

@odahcam
Copy link
Member

odahcam commented Feb 26, 2018

Done.

@odahcam odahcam closed this as completed Feb 26, 2018
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants