Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for QR Code Model 1 #1067

Closed
george-hopkins opened this issue Sep 14, 2018 · 4 comments
Closed

Support for QR Code Model 1 #1067

george-hopkins opened this issue Sep 14, 2018 · 4 comments

Comments

@george-hopkins
Copy link

In a project I recently worked on, we needed to scan some old QR codes (Model 1) as specified in ISO 18004:2000 Annex M. Due to the existing code base here, the implementation was rather straight forward.
Is there any interest in including it? (So far, only #156 and some old posts on the mailing list mention it.) If so, I would clean up my patchset and prepare a pull-request.

@srowen
Copy link
Contributor

srowen commented Sep 14, 2018

My only hesitation is how much this is worth compared to the overhead of adding, what, another thousand lines of code and tests to the project? If it's clean and tested and looks like the rest of the code base, I think it's reasonable as a new Reader type.

@george-hopkins
Copy link
Author

Alright, I completely understand your hesitation. Unfortunately the patch didn't turn as nice as I'd like to be. If anyone needs support for model 1, please feel free to check out qrmodel1 on my fork.

@Rsathishkumar87
Copy link

Rsathishkumar87 commented Sep 4, 2019

qr1nirmal
qr model1 code not decoded

@kuangguo
Copy link

好吧,我完全理解你的犹豫。不幸的是,补丁并没有像我想要的那样好。如果有人需要模型 1 的支持,请随时查看qrmodel1我的叉子

qr1nirmal qr model1 code not decoded

Have you solved it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants
@george-hopkins @srowen @Rsathishkumar87 @kuangguo and others