Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 of pages not yet implemented should redirect to imdb #50

Closed
Cwpute opened this issue Jun 1, 2023 · 1 comment
Closed

404 of pages not yet implemented should redirect to imdb #50

Cwpute opened this issue Jun 1, 2023 · 1 comment
Labels
priority: medium will look as soon as possible type: bug Something isn't working

Comments

@Cwpute
Copy link

Cwpute commented Jun 1, 2023

When searching for some imdb pages this project currently doesn't support, we're taken to a 404 page. It's ok not to have everything covered, but the original url of the page we were going for is lost in the process. Sure there is a pop-up button on the toolbar up there to go to the corresponding imdb page... but it takes you to https://www.imdb.com/404... eheh.

See for yourself the Characters sections on a Series page:

libremdb should retain the original imdb url you were going for, and for pages it doesn't cover yet, give users the opportunity to browse that exact page over at the original website.

This would be especially useful for people like mewho have activated redirectors like LibRedirect and can have a hard time accessing the original website's page

@zyachel
Copy link
Owner

zyachel commented Jun 3, 2023

Thanks for the issue!

This seems to be a limitation of Next.js(the framework I'm using for libremdb). I'll fix it.

@zyachel zyachel added type: bug Something isn't working status: in progress working on it priority: medium will look as soon as possible labels Jun 3, 2023
@zyachel zyachel closed this as completed in 0aea2f4 Jun 3, 2023
@zyachel zyachel removed the status: in progress working on it label Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium will look as soon as possible type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants