Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage of asset_filter breaks target #64

Closed
leapfog opened this issue Dec 1, 2022 · 5 comments
Closed

usage of asset_filter breaks target #64

leapfog opened this issue Dec 1, 2022 · 5 comments

Comments

@leapfog
Copy link

leapfog commented Dec 1, 2022

With the following simple config file

[global]
  target = "~/bin"
  upgrade_only = true

the command eget neovim/neovim downloads the appimage and places it in ~/bin.

But when I add

["neovim/neovim"]
   asset_filters = "nvim.appimage"

the download ends up in ./ (i.e. the current directory).

@patinthehat
Copy link
Contributor

patinthehat commented Dec 1, 2022

@leapfog It looks like this might be a bug related to the expansion of the tilde (~). Can you verify that it works correctly if you use an absolute pathname in the [global] section for target?

i.e.,

[global]
  target = "/home/someuser/bin"
  upgrade_only = true

@leapfog
Copy link
Author

leapfog commented Dec 1, 2022

No, that doesn't help.

But testing that, it seems, that adding asset_filters = "nvim.appimage" simply (and silently!) breaks reading the global section config file.

update:

using asset_filters = [ "nvim.appimage" ] makes the whole thing work.

but also #65 happens here: nvim is downloaded/overwritten every time.

@patinthehat
Copy link
Contributor

@leapfog Does using the array syntax fix this? Just trying to narrow down the possibilities here.

["neovim/neovim"]
   asset_filters = [ "nvim.appimage" ]

@hhromic
Copy link
Contributor

hhromic commented Oct 21, 2023

I think this is an effect of what I just reported in #84.
When a configuration file is malformed, eget simply ignores it and uses defaults if no other valid config files are found.
The default for target is to save the binaries in the current directory.

In that isssue I'm also proposing for eget to report configuration file errors instead of ignoring them.
This would make this kind of issues very visible and less confusing.

@zyedidia
Copy link
Owner

zyedidia commented Jun 6, 2024

I believe this is fixed by #85.

@zyedidia zyedidia closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants