Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception when facebook init fails #67

Closed
tdesvenain opened this issue Apr 6, 2017 · 2 comments
Closed

Throw an exception when facebook init fails #67

tdesvenain opened this issue Apr 6, 2017 · 2 comments

Comments

@tdesvenain
Copy link

Now that exception is catched in init() method, we can't detect if init process failed. This is very annoying.
Could we

  • throw an exception if FB.init fails
  • or refactor FacebookService.init function into a promise
  • or set a state on FacebookService that provides information about fail or success status of init ?
    Thanks
@ihadeed
Copy link
Member

ihadeed commented Apr 13, 2017

Sure, I like the promise idea. I will implement it when I get a chance.

Feel free to submit a PR!

@tdesvenain
Copy link
Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants