Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp segment in chain theme defaults to grey which is no longer valid #6

Closed
vendion opened this issue Jan 7, 2020 · 1 comment

Comments

@vendion
Copy link

vendion commented Jan 7, 2020

By default the timestamp segment is set to be colored as "grey" as per this line https://github.com/zzamboni/elvish-themes/blob/master/chain.elv#L45 but with Elvish 0.13 (and presumably going forward) "grey" is no longer a valid color for styled command:

[/u/h/v/ports]─[⎇ master]─> styled "this message should be red" red
▶ (styled (styled-segment this message should be red &fg-color=<unknown red> &bg-color=$nil))
[/u/h/v/ports]─[⎇ master]─> styled "this message should be grey" grey
Exception: grey is not a valid style transformer

The default color for this segment should be updated to be one of the other valid colors, probably "bright-black" instead as that is the closest parallel per the release notes https://elv.sh/blog/0.13-release-notes.html

@zzamboni
Copy link
Owner

zzamboni commented Jan 8, 2020

@vendion Fixed - thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants