Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The :+1: emoji is not recognized #15

Closed
mislav opened this issue Apr 5, 2016 · 3 comments
Closed

The :+1: emoji is not recognized #15

mislav opened this issue Apr 5, 2016 · 3 comments
Labels

Comments

@mislav
Copy link

mislav commented Apr 5, 2016

This is because the [\w\.]+ regex doesn't allow a literal + character.

I suggest the following regex: :([\w+-]+):

@mislav
Copy link
Author

mislav commented Apr 5, 2016

For the same reason, it's not safe to use the emoji ID to generate a classname like this gh-emoji-${id} because emojis can contain + and - characters.

@rpunkfu
Copy link
Collaborator

rpunkfu commented Apr 5, 2016

Thanks @mislav! :) I'm working on fix and tests for our new regex to avoid this type of bugs in future :)
Regarding your second comment, I proposed that we move emojis names from class tag. :)

@zzarcon
Copy link
Owner

zzarcon commented Apr 5, 2016

Fixed on v0.2.4, more info #18. Thanks for the help @mislav ^^

@zzarcon zzarcon closed this as completed Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants