Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangs / fails on Windows 7 #6

Open
wohali opened this issue Jun 20, 2019 · 2 comments · May be fixed by #7
Open

Hangs / fails on Windows 7 #6

wohali opened this issue Jun 20, 2019 · 2 comments · May be fixed by #7

Comments

@wohali
Copy link

wohali commented Jun 20, 2019

Hi there. Nice library! Working with @garbados to get support for various platforms into psaux.

Unfortunately, the ConvertTo-Json PowerShell cmdlet you're using doesn't exist in Windows 7. It's only present in PowerShell 3.0 and up and Windows 7 (along with some Windows Server versions) only have v2.0.

Worse, the library actually hangs on Windows 7 machines with PowerShell 2.0, rather than failing out.

For lack of a better term, there's a public domain "polyfill" that gives you this behaviour in PowerShell 2.0: https://github.com/EliteLoser/ConvertTo-Json

Could you include this library and use it when you detect PowerShell's version is not 3.0 or greater? Thanks!

@zzarcon
Copy link
Owner

zzarcon commented Jun 26, 2019

Hi @wohali ! Thanks for creating this. Honestly I have no context at all on how this works on Windows, current Windows support was added here #2 by @chreestopher . So he should be able to provide some light into that.

The https://github.com/EliteLoser/ConvertTo-Json looks good to me and Im happy for anyone to if wants to include it. But I can't really take over the task as Im not a Windows user :(

@garbados garbados linked a pull request Jun 28, 2019 that will close this issue
@garbados
Copy link
Contributor

garbados commented Jul 2, 2019

@zzarcon I wrote up a PR that removes dependence on the convertto-json script, thus resolving this bug. I opted for that over including the linked script because I too am not particularly proficient in programming on Windows and doing it in JavaScript wasn't ultimately very difficult. What do you think? #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants