Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter isn't removing the extra filtering #124

Closed
timalmond opened this issue Sep 25, 2017 · 2 comments
Closed

Filter isn't removing the extra filtering #124

timalmond opened this issue Sep 25, 2017 · 2 comments
Assignees

Comments

@timalmond
Copy link

I tried using the EnableFilter query and use a lambda with a function to check user level and filter as required. This function returned false, but the filter still navigated to entities that weren't required.

I found that I had to add a statement into BuildFilterExpressionWithDynamicFilters of

(!_DbContext.IsFilterEnabled(filter.FilterName)) continue;

for each filter in filterList for this to work.

I'm certain I'm doing something wrong with the configuration of DynamicFilters rather than your code, but I can't see what's wrong. I also noticed from the source that methods like PreventAllDisabledFilterConditions in DynamicFilterExtensions were not being called but I don't know why.

@JonathanMagnan JonathanMagnan self-assigned this Sep 26, 2017
@JonathanMagnan
Copy link
Member

Hello @timalmond ,

Do you think you could submit us a small example?

By example, check this example: #72 (comment)

It will help us to getting started and better understand this problem.

Best Regards,

Jonathan

@JonathanMagnan
Copy link
Member

Hello @timalmond ,

I will close this issue since no example has been provided.

If you can provide one, please reopen this issue and we will work on it.

Best Regards,

Jonathan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants