Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtmlNode.LinePosition is not accurate for attributes #288

Closed
jcoutch opened this issue Apr 3, 2019 · 3 comments
Closed

HtmlNode.LinePosition is not accurate for attributes #288

jcoutch opened this issue Apr 3, 2019 · 3 comments
Assignees

Comments

@jcoutch
Copy link

jcoutch commented Apr 3, 2019

Description

HtmlNode.LinePosition when used with attributes is never accurate (always seems to be 2 characters off.)

Exception

No exceptions thrown

Fiddle or Project

https://dotnetfiddle.net/GWS8yg

Further technical details

  • HAP version: 1.11.1
  • NET version: N/A (occurs in both NetFX and NetCore applications.)
@jcoutch
Copy link
Author

jcoutch commented Apr 3, 2019

I also checked ValueStartIndex, and as long as that's zero-based, appears to be correct. Just the LinePosition appears to be incorrect.

@JonathanMagnan JonathanMagnan self-assigned this Apr 3, 2019
@JonathanMagnan
Copy link
Member

Hello @jcoutch ,

Thank you for reporting,

My developer is currently looking at it.

Best Regards,

Jonathan


Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework ExtensionsEntity Framework ClassicBulk OperationsDapper Plus

Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval FunctionSQL Eval Function

@JonathanMagnan
Copy link
Member

Hello @jcoutch ,

The v1.11.2 has been released.

The LinePosition should be now fixed. Let me know if you get the right value.

Best Regards,

Jonathan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants