Skip to content

Make tool-cache compatible with GHES without internet access #644

Open
@OursDesCavernes

Description

@OursDesCavernes

Hello,
I am trying the preview of GitHub Actions on GitHub Enterprise Sever and found that tool-cahe was hard linked to the public GitHub:
https://github.com/actions/toolkit/blob/main/packages/tool-cache/src/tool-cache.ts#L557

Using the modified context from #576 or process.env.GITHUB_HOST ?? "https://api.github.com directly would solve the issue.

I've not searched yet for other similar issues in the toolkit. This was where the toolkit died first because it didn't have internet access.

Activity

stevenh

stevenh commented on Jan 18, 2022

@stevenh

Just spotted this too. It was raised back in 2020, can we get an update, looks like a really simple fix?

added a commit that references this issue on Jan 18, 2022
584c6fe
linked a pull request that will close this issue on Jan 18, 2022
naikrovek

naikrovek commented on Feb 2, 2022

@naikrovek

This is an easy fix and the PR is ready. Please merge it and close this silly issue 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @stevenh@naikrovek@OursDesCavernes@thboop

      Issue actions

        Make tool-cache compatible with GHES without internet access · Issue #644 · actions/toolkit