(GH-407) Support negative integers in manifest exitCodes
#410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeltlombardi
force-pushed
the
gh-407/main/update-exit-code-schemas
branch
2 times, most recently
from
01b8fcf
to
80fbd0e
Compare
SteveL-MSFT
reviewed
Apr 18, 2024
SteveL-MSFT
previously requested changes
Apr 18, 2024
michaeltlombardi
force-pushed
the
gh-407/main/update-exit-code-schemas
branch
from
ed44215
to
5aef8a3
Compare
Prior to this change, the JSON schema for the `exitCodes` property of resource manifests only supported positive integers as exit codes. DSC itself supports negative integers as exit codes, and some apps return negative integers as exit codes for hexadecimal exit codes, like `-2147024891` for `0x80070005`, "Access denied." This change: - Updates both the source and composed schemas to allow negative integers. - Updates the reference documentation to clarify that you must specify integers, that you can't use any alternate formats for those integers, and that the keys in YAML must be wrapped in quotes for parsing. - Addresses PowerShell#407 by making the schema compliant with the implementation.
michaeltlombardi
force-pushed
the
gh-407/main/update-exit-code-schemas
branch
from
5aef8a3
to
916548c
Compare
michaeltlombardi
dismissed
SteveL-MSFT’s stale review
Addressed change request.
SteveL-MSFT
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This change:
PR Context
Prior to this change, the JSON schema for the
exitCodesproperty of resource manifests only supported positive integers as exit codes.DSC itself supports negative integers as exit codes, and some apps return negative integers as exit codes for hexadecimal exit codes, like
-2147024891for0x80070005, "Access denied."Note
This PR builds on #397 and is blocked on that PR being reviewed and merged.