Skip to content

Commit

Permalink
Disable Azure Pipelines CI for release branch
Browse files Browse the repository at this point in the history
It is completely superfluous because the release pipeline runs the exact same CI
template. Moreover, because it's a different Azure organization, the NPM
authentication won't work without setting up and managing a service connection.

Run the GitHub Actions CI with the Release configuration.

Also run the NPM install scripts because sometimes it will break without them.
  • Loading branch information
andyleejordan committed Mar 6, 2024
1 parent 91f1044 commit dd0315e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:

- name: Build, test and package
shell: pwsh
run: Invoke-Build
run: Invoke-Build -Configuration Release
env:
NPM_PASSWORD: ${{ secrets.AZURE_NPM_PASSWORD_BASE64}}

Expand Down
7 changes: 2 additions & 5 deletions .vsts-ci/azure-pipelines-ci.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
name: CI-$(Build.SourceBranchName)-$(Date:yyyyMMdd)$(Rev:.rr)

# NOTE: This was superceded by the GitHub Actions workflow.
pr: none

trigger:
branches:
include:
- release
trigger: none

variables:
# Don't download unneeded packages
Expand Down
2 changes: 1 addition & 1 deletion vscode-powershell.build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ task RestoreNodeModules -If { !(Test-Path ./node_modules) } {
# When in a CI build use the --loglevel=error parameter so that
# package install warnings don't cause PowerShell to throw up
if ($env:CI -or $env:TF_BUILD) {
Invoke-BuildExec { & npm ci --loglevel=error --ignore-scripts }
Invoke-BuildExec { & npm ci --loglevel=error }
} else {
Invoke-BuildExec { & npm install }
}
Expand Down

0 comments on commit dd0315e

Please sign in to comment.