-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Client side Rename provider to allow variable/function rename #4950
base: main
Are you sure you want to change the base?
Conversation
…owershell into rename-provider
@microsoft-github-policy-service agree |
Hi @Razmo99 super appreciate the detailed PR! Just want to give you a heads up that the maintainers are all pretty heads down on commitments at the moment so it may be a couple of weeks before we get a chance to review the PR |
I would like to ask, what is the state of this PR, does it work actually? I fastly scrolled through the proposed PR and also PowerShellEditorServices#2152, looks like @Razmo99 did a great job about The code quality looks good to me and contains a lot of tests, which is a good thing. Would it be possible to review it, git checkout it, test it, and release it in the next version? @andyleejordan I lack renaming in PS extension so much, would greatly boost dev. productivity in many cases. I know there always is Search & Replace, but properly implemented rename refactorings are gold in some cases 🙂 To just hit ctrl+shift+r or f2 and rename the symbol under the cursor, to avoid classic search and replace. I know that the PR is huge, but also the functionality is complex. |
I would really like to get this feature in, yes. However, we're currently paused on feature work for a bit while some security work takes priority. Said another way: please expect to see it within the year, but probably not in the next month. |
Ok, thx for stating it out, would be nice to make it a little quicker but whatever, at least check-in it out and test it to see if it works and in which state the PR is would be a good idea. I think that having a new feature like this is more interesting for developers than having npm packages at the latest versions every month or every release 😁 |
PR Summary
This pull request implements the VSCode
RenameProvider
class along with two methods within itprovideRenameEdits
andprepareRename
the goal being to complete #261This will allow for the client to make requests to the server side of the extension when pressing F2 to perform refactoring on variables and functions.
This client side code has been modified from the C# VSCode extension and modified to work with the Powershell extension's server side component.
There will be a sister pull request on the PowershellEditorServices repository to implement the server side.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets.Please mark anything not applicable to this PR
NA
.WIP:
to the beginning of the title and remove the prefix when the PR is ready