Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hypertile xyz #15831

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fix Hypertile xyz #15831

wants to merge 3 commits into from

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented May 18, 2024

Description

Hypertile's xyz support was was implemented in a way that once the axis is processed the setting is permanently changed even after job has finished

changes

  • re-implement Hypertile's xyz support using apply_override so setting are not permanent
  • create new xyz util confirm_range for checking of all values are in range
  • minor reformat of scripts/xyz_grid.py (there's a couple of weird indents)

about confirm_range
initially I was going to implement something that can specify more complex ranges using the mathematical interval notation
but at the end I feel like it's overkill
https://gist.github.com/w-e-w/cac0787539a8163b94315c8d587ba952

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner May 18, 2024 10:00
@w-e-w
Copy link
Collaborator Author

w-e-w commented May 18, 2024

@aria1th
just in case there is something I don't know
why is there the need of chacking existing Hypertile axis
as far as I'm aware there's no chance of this ever happening since

set_a = {opt.label for opt in xyz_grid.axis_options}
set_b = {opt.label for opt in extra_axis_options}
if set_a.intersection(set_b):
return

@aria1th
Copy link
Collaborator

aria1th commented May 18, 2024

While I was implementing this, reloading extensions has resulted multiple identical options in gradio dropdown box so I temporarily added check for this
I think the bug has been resolved somewhere, and we don't have to maintain the check now

@w-e-w
Copy link
Collaborator Author

w-e-w commented May 18, 2024

While I was implementing this ... I think the bug has been resolved somewhere

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants