CHIA-618 Explore limiting replace by fee to only one spend bundle #18006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineKhaldi
added
Changed
arvidn
reviewed
May 20, 2024
AmineKhaldi
force-pushed
the
rbf_only_one_tx
branch
from
f81fdf1
to
5c86982
Compare
|
let's wait for the architecture call to have a wider discussion about this. I think it makes sense as a short-term improvement. |
arvidn
reviewed
May 23, 2024
| @@ -599,7 +599,7 @@ async def validate_spend_bundle( | |||
|
|
|||
| if fail_reason is Err.MEMPOOL_CONFLICT: | |||
| log.debug(f"Replace attempted. number of MempoolItems: {len(conflicts)}") | |||
| if not can_replace(conflicts, removal_names, potential): | |||
| if len(conflicts) > 1 or not can_replace(conflicts, removal_names, potential): | |||
There was a problem hiding this comment.
the point of this is to remove the super-set rule as well, right?
in can_replace()
AmineKhaldi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea suggested by @Rigidity.