add pin comment #932
Open
add pin comment #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
DIYgod
requested changes
Aug 21, 2023
| if (aIsPinned !== bIsPinned) { | ||
| return bIsPinned - aIsPinned | ||
| } | ||
| const aDate = new Date(a.updatedAt) |
| const { t } = useTranslation("common") | ||
|
|
||
| const data = comments.data?.pages.filter( | ||
| (page) => (page?.list?.length ?? 0) > 0, | ||
| ) | ||
| const sortedData = data?.map((item) => { |
There was a problem hiding this comment.
The logic should be placed within pageModel.getComments, and the pinned comment should be requested separately to ensure that it is always returned. You can refer to pinnedNote in getPagesBySite.
| @@ -829,6 +831,7 @@ export async function updateComment( | |||
| content, | |||
| tags: ["comment"], | |||
| sources: ["xlog"], | |||
| pinned, | |||
There was a problem hiding this comment.
You cannot use pinned here because it does not comply with the Note Metadata specs. Instead, you can place it in the attributes field.
Thank you, I will make some modifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
馃 Generated by Copilot at 369327d
Added the ability to pin and unpin comments on pages. This feature allows users to highlight important or relevant comments and sort them by priority. Modified the
Comment,CommentItem, andpagecomponents and models, and added Chinese translations for the pin-related UI.馃 Generated by Copilot at 369327d
WHY
I want to pin some comments
HOW
馃 Generated by Copilot at 369327d
useUpdateCommenthook to enable pinning comments (link, link, link, link, link)VirtualList(link, link)pinnedstate and prop toCommentItemcomponent and conditionally render pin button (link, link)pinnedparameter toupdateCommentfunction in page model and update comment metadata on blockchain (link, link)CLAIM REWARDS
xlog: https://raye.xlog.app/
discord: rayepeng
For first-time contributors, please leave your xLog address and Discord ID below to claim your rewards.