Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize residual comps #2843

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Normalize residual comps #2843

wants to merge 3 commits into from

Conversation

mtzguido
Copy link
Member

@mtzguido mtzguido commented Mar 7, 2023

The normalizer is not currently reducing lambdas in the types of residual comps in Tm_abs and Tm_match nodes. This simple patch makes it so, opening the PR just to:

  • Make sure this is in fact desirable?
  • Confirm that performance is acceptable. I ran the diff script and got the images below, with mixed results. I understand the <1 slope means that things are in average slightly better?
  • Point to the last patch, which works around another gensym-related Heisenbug! I don't plan to get that commit to master, just adding it here to get a green. It will hopefully go away once other patches land.

I ran into this while trying to removing Tm_names from checked files, and some remained in unreduced residual comps. They should not be there anyway.. as it's supposed to be closed, but still tracking that down.

Figure_1
Figure_2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant