Add [@@no_inline_let] annotation
#3169
Open
+38
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amosr
force-pushed
the
amos/noinlinelet
branch
from
d78eaf9
to
f566d31
Compare
amosr
force-pushed
the
amos/noinlinelet
branch
from
f566d31
to
7d50ab4
Compare
|
Hi Amos, sorry this dropped off the radar. If it's still useful I'd be fine with merging this as-is. |
|
Hi Guido, Yes, this is still useful to me - I haven't been able to find another good way to have precise control over inlining with norm |
|
(Sorry - I actually accidentally pressed the 'merge from master' button. I'll get this building again in the next few days) |
|
It was just some flaky failure. I pushed a fix to this PR. It would be good to get a test for this somewhere in the repo though. |
|
Oh, thanks. Good idea - I'll try to make one soon. Do you have a preference whether I put it as a separate PR or modify this one? |
|
Probably better to just append to this one... but no big deal either way! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
[@@no_inline_let]annotation so that the norm tactic doesn't always unfold local lets.I had to update the rlimit in some places. Some of these were necessary to get the current master building on MacOS even without the no_inline_let changes, but others were required by the no_inline_let. Perhaps the annotation should be hidden in a separate module to avoid polluting the pervasives namespace?