Ported "Up Arrow key cycles through Query history" PR #2696
Conversation
- Add Reset CycleIndex when close window
VictoriousRaptor
force-pushed
the
240516GarulfQueryCycle
branch
from
e63c42e
to
3d6d79b
Compare
| @@ -1116,6 +1163,7 @@ public void Show() | |||
|
|
|||
| public async void Hide() | |||
| { | |||
| lastHistoryIndex = 1; | |||
There was a problem hiding this comment.
Why is this reset needed?
There was a problem hiding this comment.
If you close the window and start the cycle again, you should see the most recent query first.
If a user set last query style to preserve or selected that means he wants to continue the working state if so. Maybe better to reset it only when empty?
There was a problem hiding this comment.
Why is this reset needed?
When the user closes the window, the index is initialized. Lastemptyquery is just a setting about query input, so it shouldn't have anything to do with this setting. It's kind of weird when I try it in without doing this initialization. When a new window opens, we should assume that the user is starting fresh. (For example, if the user puts in a few queries and then opens the flow again an hour later and does not initialize when using this feature, the user will skip commands that he does not remember.) Get rid of it and try it. It's weird.
There was a problem hiding this comment.
If you close the window and start the cycle again, you should see the most recent query first.
If a user set last query style to preserve or selected that means he wants to continue the working state if so. Maybe better to reset it only when empty?
It is also not a good idea to initialize when user delete a query. Not closing the window means that the user intends to keep it that way. When using the function in other cli programs, the index is maintained even if the query is deleted. This is a feature that cli users will mainly use, so it's right to follow this UX.
|
LGTM. |
What's the PR
Todo
Test Cases
ETC