add a close overload for jsonrpcpluginv2 #2700
Conversation
| } | ||
| catch (Exception e) | ||
| { | ||
| Log.Exception( |
There was a problem hiding this comment.
Is this the case where the plugin hasn't imemted the 'close' method? If so do we need to be logging it?
There was a problem hiding this comment.
This is not the case that plugin didn't implement the close method. This part is for all other excpetions, which we should log it or throw it maybe? well I guess it's better to just rethrow it.
That is the previous exception branch. I don't think we really need to log it, because if plugin doesn't have the close method, we can safely assume that they don't need it. Further, given that we already release jsonrpc v2 even though without documentation and as prerelease, it may be a problem to break the backward compatibility. And it doesn't gain us anything for logging it, unless we mark it as exception?
|
LGTM, just remove the Logger import since you're no longer logging anything. |
Send a request to jsonrpcv2 when flow is closing.