Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes the size of the icons #495

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Changes the size of the icons #495

wants to merge 2 commits into from

Conversation

AnuragNishad12
Copy link
Contributor

@AnuragNishad12 AnuragNishad12 commented Oct 30, 2023 •
edited by coderabbitai bot

before :-

image

after:-

image

Summary by CodeRabbit

New Feature:

  • Added a new library, Web3.py, to the list of libraries. This Python library allows for interaction with Ethereum.

Documentation:

  • Introduced a new page dedicated to the Web3.py library, providing a brief introduction to its functionalities.
  • Minor changes to the learnweb3.md file for improved readability.

Style:

  • Updated CSS styles for images in Markdown files. The changes include adjustments to the maximum width, margin, and display properties of images, enhancing the visual layout and user experience.

@vercel
Copy link

vercel bot commented Oct 30, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
free-web3-resources ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 7:11pm
free-web3-resources-1l9i ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 7:11pm

@coderabbitai
Copy link

coderabbitai bot commented Oct 30, 2023 •
edited

Walkthrough

The recent changes encompass the addition of a new library, Web3.py, to the Ethereum ecosystem documentation, along with a brief introduction to it. Additionally, the CSS styles for images in Markdown files have been modified to enhance their display and positioning.

Changes

File Path Summary
docs/courses/... Three empty lines added.
docs/libraries/... Added Web3.py to the list of libraries.
docs/libraries/web3py.md Introduced a new Markdown front matter section and a brief introduction to Web3.py.
src/css/custom.css Modified CSS styles for images in Markdown files, affecting their size, positioning, and display.

Poem

🍂 As the autumn leaves fall, we code and tweak, 🍁
In the world of Ethereum, a new library we seek. 🌐
Web3.py, a new friend, comes into the light, 💡
With CSS changes making images just right. 🖼️
Celebrate the changes, for they are neat, 🎉
CodeRabbit's work, never missing a beat. 🐇
So here's to the season, full of color and fun, 🎃
And to the joy of coding, never to be outdone! 💻🌟

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@AnuragNishad12 AnuragNishad12 mentioned this pull request Oct 30, 2023
Closed
1 task
coderabbitai[bot]
coderabbitai bot reviewed Oct 30, 2023
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 98ecfc3 and fa909a3.
Files selected for processing (4)
  • docs/courses/learnweb3.md (1 hunks)
  • docs/libraries/libraries.md (1 hunks)
  • docs/libraries/web3py.md (1 hunks)
  • src/css/custom.css (1 hunks)
Files skipped from review due to trivial changes (3)
  • docs/courses/learnweb3.md
  • docs/libraries/libraries.md
  • docs/libraries/web3py.md

src/css/custom.css
Comment on lines 843 to 848
.markdown img {
max-width: min(600px, 100%);
margin: 0 auto 1.5rem auto;
display: block;
max-width: min(50px, 100%);
margin: 2 auto 2rem auto;
display:inline-block;
border: 2px solid var(--cabbage60);
}
Copy link

@coderabbitai coderabbitai bot Oct 30, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the CSS properties for .markdown img seem to be fine. However, the margin property seems to be incorrect. The margin shorthand property takes 1, 2, 3, or 4 values. In this case, it seems like you're trying to use 4 values (top, right, bottom, left), but you've only provided 3. If you want to set a margin of 2 pixels on the top and bottom and auto on the left and right, you should use 2px auto. If you want to set a margin of 2 pixels on the top, auto on the right and left, and 2rem on the bottom, you should use 2px auto 2rem.

-  margin: 2 auto 2rem auto;
+  margin: 2px auto 2rem;
Commitable suggestion (Beta)
Suggested change
.markdown img {
max-width: min(600px, 100%);
margin: 0 auto 1.5rem auto;
display: block;
max-width: min(50px, 100%);
margin: 2 auto 2rem auto;
display:inline-block;
border: 2px solid var(--cabbage60);
}
.markdown img {
max-width: min(50px, 100%);
margin: 2px auto 2rem;
display:inline-block;
border: 2px solid var(--cabbage60);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnuragNishad12 Great! If you have any other questions or need further clarification, feel free to ask.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do u merged this or not ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnuragNishad12 As an AI, I don't have the ability to merge pull requests. You'll need to merge the changes yourself or ask a project maintainer to do so. If you have any other questions, feel free to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AnuragNishad12