add config command #181
Open
add config command #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # database/server.go
HDT3213
requested changes
May 28, 2023
database/config.go
Outdated
| if len(args)%2 != 0 { | ||
| return protocol.MakeErrReply("ERR wrong number of arguments for 'config|set' command") | ||
| } | ||
| properties := config.CopyProperties() |
There was a problem hiding this comment.
因为config set是原子性的，所以我希望拷贝一份配置对象，然后先在这个对象上进行修改，最后的时候再将原本的配置文件对象指向这个修改后的对象
There was a problem hiding this comment.
因为线程可见性的原因，在没有使用 mutex 或 atomic 等并发原语的情况下是无法保证原子性的。建议了解一下 happens-before, 线程可见性和指令重拍等内容
There was a problem hiding this comment.
这里我加了个mutex，或者可以给个别的思路嘛，如何保证同时多个配置时的原子性
HDT3213
requested changes
Jun 5, 2023
database/config.go
Outdated
| if len(args)%2 != 0 { | ||
| return protocol.MakeErrReply("ERR wrong number of arguments for 'config|set' command") | ||
| } | ||
| properties := config.CopyProperties() |
There was a problem hiding this comment.
因为线程可见性的原因，在没有使用 mutex 或 atomic 等并发原语的情况下是无法保证原子性的。建议了解一下 happens-before, 线程可见性和指令重拍等内容
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.