Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl-cnpg: Enable auto-completion as kubectl plugin #172071

Merged
merged 2 commits into from
May 19, 2024

Conversation

Skaronator
Copy link
Contributor

@Skaronator Skaronator commented May 18, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

I am not sure if this is the correct homebrew way but to get the auto-completion working as kubectl plugin we need one more binary called kubectl_complete-cnpg

The whole thing is documented here: https://github.com/cloudnative-pg/cloudnative-pg/blob/main/docs/src/kubectl-plugin.md#configuring-auto-completion

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label May 18, 2024
@Skaronator Skaronator marked this pull request as ready for review May 18, 2024 19:40
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 19, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 19, 2024
Merged via the queue into Homebrew:master with commit 7575760 May 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants