Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add the TI DRL0006A footprint for TPD4E1B06DRL #2485

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Doeme
Copy link

@Doeme Doeme commented Sep 23, 2020

Refer to The Process here:
KiCad/kicad-symbols#2256

http://www.ti.com/lit/ds/symlink/tpd4e1b06.pdf

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2020

CLA assistant check
All committers have signed the CLA.

@Doeme
Copy link
Author

Doeme commented Sep 23, 2020

i dont know what the ci is whining about, can anybody explain? There is a %R Test on the f.fab layer.

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Sep 24, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Sep 24, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Sep 24, 2020
@myfreescalewebpage
Copy link
Collaborator

@Doeme thanks to submit this footprint. Two comments to start the review:

  • It's impossible to open the footprint with kicad, I have an error while opening
  • Reference on the F.Fab layer should be %R (see travis error)
  • The 3D path definition is missing in the file (to be added even if it does not exist yet)

For this simple footprint I expect travis with no error no warning. I suggest to copy SOT footprint and modify the dimensions, it will be easier !

Joel

@chschlue
Copy link
Contributor

I think this has been created with a v5.99 nightly build, telling by the tstamp attributes and such.

@Doeme please use v5.1 for now

@myfreescalewebpage
Copy link
Collaborator

@Doeme ping

@Doeme
Copy link
Author

Doeme commented Sep 30, 2020

@myfreescalewebpage pong, I was on holiday, with very limited internet access, and generally a no touchy-touchy rule for the laptop (the Alps were gorgeous :)

I'll recompile kicad tomorrow. Hopefully this will also help to please the CI, since I did add this %R text it's complaining about.

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Sep 30, 2020

@Doeme no problem of course. I know the Alps are gorgeous, I born in the Alps :)
I keep PR ongoing, but on your side please use delivered version available for download at https://kicad-pcb.org/download/ to create footprint

@Doeme
Copy link
Author

Doeme commented Oct 1, 2020

okay, downgrading to v5.1 seems to have fixed the CI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants