Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Onion_Omega2S 3D .step and .wrl models #655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Onion_Omega2S 3D .step and .wrl models #655

wants to merge 1 commit into from

Conversation

chmorgan
Copy link
Collaborator

@chmorgan chmorgan commented Feb 6, 2020

Generated from kicad stepup tools from FreeCAD 0.19.

Lazar Demin lazar@onion.io, CTO of Onion, has personally and explicitly granted the author of this commit,
Chris Morgan chmorgan@gmail.com, permission to add this model to KiCad for public usage.

Replace this line with your commit message! Please provide a description of your pull request


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items as you complete them:

  • A screenshot of the model(s) aligned with KiCad footprints is very useful
  • Was the 3D model(s) created in a mechanical modelling program?
  • Source files (or scripts) have been contributed
  • Step model submitted in 1:1 scale
  • WRL model submitted in 1:2.54 scale
  • 3D model alignment checked against KiCad footprint
  • WRL model uses correct material properties
  • Geometry check performed against mechanical models

Generated from kicad stepup tools from FreeCAD 0.19.

Lazar Demin <lazar@onion.io>, CTO of Onion, has personally and explicitly granted the author of this commit,
Chris Morgan <chmorgan@gmail.com>, permission to add this model to KiCad for public usage.
@claassistantio
Copy link

claassistantio commented Feb 6, 2020

CLA assistant check
All committers have signed the CLA.

@chmorgan
Copy link
Collaborator Author

chmorgan commented Feb 8, 2020

omega2s_3d_side

omega2s_3d_top

@chmorgan
Copy link
Collaborator Author

chmorgan commented Feb 8, 2020

I believe this model and the corresponding PR in the source repo, KiCad/kicad-packages3D-source#263 meet the KLC requirements.

@chmorgan
Copy link
Collaborator Author

@Misca1234 it looks like you are active in this and the kicad-packages3D-source repositories, apologies for bugging you if you aren't the right person. I'm trying to find out who/when this and the source PRs might be reviewed.

@poeschlr
Copy link
Collaborator

Your contribution will be reviewed when it will be reviewed. Everyone here is a volunteer and you might notive by looking around that we have > 500 pull requests to deal with spread out over multiple repos.

@poeschlr poeschlr added Addition Adds new package 3D to library Pending reviewer A pull request waiting for a reviewer labels Feb 18, 2020
@chmorgan
Copy link
Collaborator Author

chmorgan commented Mar 7, 2020

@poeschlr I can appreciate that. Anything I can do to help move this forward?

@poeschlr
Copy link
Collaborator

poeschlr commented Mar 7, 2020

Just review stuff. Compare footprints, symbols or 3d models against datasheets and show your findings for the maintainers.

@chmorgan
Copy link
Collaborator Author

chmorgan commented Mar 8, 2020

Hi @poeschlr. I've reviewed a handful of open PRs and provided feedback. I can continue reviewing them but wanted to wait until those were through the process (merged or closed) before reviewing more of them. What are the next steps?

@poeschlr
Copy link
Collaborator

poeschlr commented Mar 8, 2020

I did not mean to imply that i will take time out of my day to review your stuff if you review pull request. You asked how you can help and i gave you an answer. So in the end this means you will need to be patient.
We are simply not enough volunteers and the ones that are here do not have the time available they would love to have. I for example have a full time job, need to finish my thesis and then need to balance my family live and time to meet my friends with my hobbies like working on KiCad. (And even my time on KiCad is split between developing the footprint generator scripts, reviews of library contributions, writing tutorials and helping out on the forum.)

@chmorgan
Copy link
Collaborator Author

chmorgan commented Mar 8, 2020

@poeschlr I appreciate that, I was more asking about the process and who else was involved. Are there other reviewers / committers that I might be able to work with?

@poeschlr
Copy link
Collaborator

poeschlr commented Mar 8, 2020

We don't have a strict rule who does what. Every maintainer does what they have time for or are interested in. I mostly work on the footprint and scripting side of things. I really mostly answered above because i generally also answer things like "i am inpatient please do my stuff first" (mostly by telling the user in question to be patient as i did here)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new package 3D to library Pending reviewer A pull request waiting for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants