Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add HT42B534 USB to UART IC #2695

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thatoddmailbox
Copy link
Contributor

@thatoddmailbox thatoddmailbox commented May 3, 2020

Datasheet: https://www.holtek.com/documents/10179/11842/HT42B534-xv110.pdf

There are four different packages, and they each have different pinouts, so I made four symbols. The datasheet doesn't give any different part numbers for the packages, so I just added Holtek's names for the packages to end of the symbol names.

10MSOP:
image

10SOP:
image

16NSOP:
image

8SOP:
image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels May 4, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Aug 24, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 24, 2020
@myfreescalewebpage
Copy link
Collaborator

Hello @thatoddmailbox and thanks for these symbols

4 symbols is the correct solution. Can you please fix the branch conflict to permit starting the review ?

Thanks
Joel

@thatoddmailbox
Copy link
Contributor Author

@myfreescalewebpage OK, the conflict should be fixed now!

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Aug 26, 2020

Hi @thatoddmailbox , thanks!

A few comments I have during my review:

HT42B534-x-8SOP

  • Description should ends with package name: USB to UART Bridge IC, SOP-8

HT42B534-x-10MSOP

  • Description should ends with package name: USB to UART Bridge IC, MSOP-10

HT42B534-x-10SOP

  • Description should ends with package name: USB to UART Bridge IC, SOP-10
  • Footprint should be SOP: Package_SO:SOP-10_3.9x4.9mm_P1.00mm and fp filter SOP*3.9x4.9mm*P1.00mm*

HT42B534-x-16NSOP

  • Description should ends with package name: USB to UART Bridge IC, NSOP-16
  • Footprint should be SOP: Package_SO:NSOP-16_3.9x9.9mm_P1.27mm and fp filter NSOP*3.9x9.9mm*P1.27mm*

Important note: repo will be locked the 2020-09-01. No new PR will be possible until KiCad V6 release. If you want to have the symbols merged quickly, you should propose the missing footprints ASAP.

Cheers,
Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Aug 26, 2020
@thatoddmailbox
Copy link
Contributor Author

@myfreescalewebpage OK, I've updated the descriptions and changed the footprint names. What I ended up doing was copying the existing footprints and renaming them to match Holtek's name. You can compare the Holtek datasheet with the datasheets for the original footprints and see that the dimensions are the same.

The pull requests for the symbols is: KiCad/kicad-footprints#2432

@myfreescalewebpage
Copy link
Collaborator

Thanks, no more comment here, just need to wait the footprints.

@cpresser
Copy link
Contributor

cpresser commented Sep 9, 2020

I am not sure that I agree that we should put duplicates of footprints into the footprint-repo just because some manufacturer choose to rename them. That just generates more uncertainty for the user, maintaining effort for us and is just bloat.
How about putting both package names into the description of the symbol and adding using the standard footprint and filter.

@myfreescalewebpage
Copy link
Collaborator

@cpresser I understand the position.
But the issue is : is it 100% identical ? even the height of the device for the package 3D ?
Moreover, later when users are taking the part in the library, if the footprint name do not correspond, they may have some doubts about the definition of the symbol.
The same issue exists with SO, SOP and SOIC for example.
We have no clear rules about this problem at the moment.
Joel

@myfreescalewebpage
Copy link
Collaborator

No news of the author on the fp, indicate this is Abandoned

@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Sep 29, 2020
@myfreescalewebpage myfreescalewebpage removed the Abandoned Original author has stopped working on the PR label Sep 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants