Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

S9014 BJT #2810

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

S9014 BJT #2810

wants to merge 4 commits into from

Conversation

elasticdotventures
Copy link

Found a common but missing BJT


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • [ x] Provide a URL to a datasheet for the symbol(s) you are contributing
  • [ x] Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • [ x] Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2020

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jun 25, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Aug 23, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 23, 2020
@myfreescalewebpage
Copy link
Collaborator

Hi @elasticdotventures , thanks for contributing,

A comment I have during my review:

  • Do you have a datasheet on the website of the manufacturer ?

Cheers,
Joel

@myfreescalewebpage
Copy link
Collaborator

@elasticdotventures ping

@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants