Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add female variants of coaxial connector symbols #2837

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ferdymercury
Copy link
Contributor

@ferdymercury ferdymercury commented Jul 2, 2020

Generic connectors in the symbol library usually have male and female variants. Coaxial connectors were missing the female variant, which is now added in this PR.

image

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
  • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@ferdymercury
Copy link
Contributor Author

ferdymercury commented Jul 2, 2020

Side note, this is how other software tends to depict coaxial connectors, with a kink in the cable rather than a hole in the outer circle:
image

@ferdymercury
Copy link
Contributor Author

We could discuss if we want to change it to something like:
image

@ferdymercury
Copy link
Contributor Author

This is the variant in https://www.ohwr.org/projects/pmtlib
image

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jul 5, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Aug 24, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 24, 2020
@myfreescalewebpage
Copy link
Collaborator

Hello @ferdymercury and thanks for contributing,

Does the design refer to a specific norm or usage ? Can you provide examples ?

The current "Conn_Coaxial" symbol can be used with male or female parts. I personally used with UFL, SMA, RPSMA etc connectors without any trouble and I don't think I have seen your design on schematics in the past.

Thanks to clarify,

Joel

@ferdymercury
Copy link
Contributor Author

Thanks!

I understand that one can use the same connector symbol for male or female parts.

But why is there then a male and female variant for a normal connector, and not for a BNC one?

image

What I did was just to copy these symbol style, having the open circle as a mark for female.

@ferdymercury
Copy link
Contributor Author

Concerning the norm, I am not sure, I just followed the style that was in Conn_01x01_Female adapted on top the current BNC symbol.

Maybe this discussion helps: https://forum.kicad.info/t/correct-connector-symbols-to-use-iaw-iec-60617/3923

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Aug 25, 2020

In this case I suggest to rename the existing symbols with "_Female" + create "_Male" symbols with colored circle.
This will make something similar to the DB connectors: males with plain circle and females with background color circle.

I think the idea is not bad I just look after consistency across the library and references or norm.

@ferdymercury
Copy link
Contributor Author

Thanks for the input!

Concerning renaming the existing symbols as _Female, wouldn't that break compatibility with older schematics?

@myfreescalewebpage
Copy link
Collaborator

It will. But we are very closed to KiCad V6, and breaking changes are permitted for that.
The only consequence for you is that we will have to wait a bit before merging your PR.
The agenda is to start merging breaking change for v6 beginning of September, it's very closed !

@ferdymercury
Copy link
Contributor Author

I was checking, and the problem with using a filled circle for male, is that it would conflict with what we have now for Coaxial_Power. So I am not sure what to do...

@myfreescalewebpage
Copy link
Collaborator

I'm not sure either.
@poeschlr and @evanshultz if you have time to think about this issue ?
Joel

@ferdymercury
Copy link
Contributor Author

(The semicircle idea I had proposed, I had copied from Conn_01_Female connector style)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants