Android check python version #460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roxell
force-pushed
the
android-check-python-version
branch
from
5109556
to
ea5496e
Compare
liuyq
reviewed
Aug 11, 2023
| @@ -42,7 +42,7 @@ if [ "${SKIP_INSTALL}" = "true" ] || [ "${SKIP_INSTALL}" = "True" ]; then | |||
| else | |||
| ! check_root && error_msg "Please run this script as superuser!" | |||
| #install_deps "git python python-lxml python-pil python-setuptools python-requests python-matplotlib python-requests ca-certificates curl tar xz-utils" "${SKIP_INSTALL}" | |||
| install_deps "python3.9 python3-distutils git ca-certificates curl tar xz-utils" "${SKIP_INSTALL}" | |||
There was a problem hiding this comment.
why you want to drop .9 here?
liuyq
reviewed
Aug 11, 2023
| curl "${url_pip}" -o get-pip.py | ||
| sudo python3 get-pip.py | ||
| sudo pip install virtualenv | ||
| pip --version | ||
| virenv_dir=python-workspace | ||
| virtualenv --python=python3.9 ${virenv_dir} |
There was a problem hiding this comment.
what's the reason to drop ".9" here?
liuyq
reviewed
Aug 11, 2023
| java_path="/usr/lib/jvm/java-17-openjdk-amd64/bin/java" | ||
| fi | ||
|
|
||
| PKG_DEPS="coreutils usbutils curl wget zip xz-utils python-lxml python-setuptools python-pexpect aapt lib32z1-dev libc6-dev-i386 lib32gcc1 libc6:i386 libstdc++6:i386 libgcc1:i386 zlib1g:i386 libncurses5:i386 python-dev python-protobuf protobuf-compiler python-virtualenv python-pip python-pexpect psmisc" |
There was a problem hiding this comment.
some of them are not available for 20.04, if you specify SKIP_INSTALL to false, and run on 20.04 host, it will fail.
liuyq
reviewed
Aug 11, 2023
| @@ -22,6 +30,7 @@ case "${dist}" in | |||
| ;; | |||
| esac | |||
|
|
|||
| chech_python_version "$(python --verison)" "3.8" "Error" | |||
There was a problem hiding this comment.
FYI, if like running Android11 cts/vts, python3.8 is not required, in fact it's just required for the AOSP master from now on. In the case of running Android11 cts/vts on Ubuntu18.04, python3.8 needs to be installed manually, otherwise it will fail here.
roxell
force-pushed
the
android-check-python-version
branch
2 times, most recently
from
f10d64f
to
c4b62b2
Compare
Add a generic way to check python version if a specific minimum version is needed. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Don't hardcode installing python3.9, because the call trace says >=python3.9, so later versions works too. Add a check that error's out if the installed python version isn't >=3.9. Fixes: 7220645 ("apk-automation: install and use python3.9") Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Readd install_deps so the test can install the correct dependencies without having to find them. Add a python version check that errors out if the python version isn't >=3.8. Fixes: 2caa92b ("noninteractive-tradefed: change to work with python3") Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
roxell
force-pushed
the
android-check-python-version
branch
from
c4b62b2
to
7154752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.