Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automated: linux: add switch-apps test for LmP #504

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

mwasilew
Copy link
Contributor

This test uses external infrastructure to force app updated on FoundriesFactory registered device running LmP.

"
}

while getopts "f:a:e:d:u:h" opts; do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asssuming in this file you prefer to do the "do" on a separate line, can we do that here too?

# enabling lmp-device-auto-register variant
systemctl enable --now lmp-device-auto-register || error_fatal "Unable to register device"

while ! systemctl is-active aktualizr-lite; do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

sleep 1
cat /var/sota/ota.signal
done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

echo "Sleeping 1s"
sleep 1
cat /var/sota/ota.signal
done
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we fix the whitespaces vs tabs in this file?

@@ -0,0 +1,30 @@
# SPDX-License-Identifier: GPL-2.0-only
# Copyright (C) 2023 Foundries.io
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the year.

This test uses external infrastructure to force app updated on
FoundriesFactory registered device running LmP.

Signed-off-by: Milosz Wasilewski <milosz.wasilewski@foundries.io>
@mwasilew
Copy link
Contributor Author

@roxell all fixed, thanks for review!

@roxell roxell merged commit 723fba8 into Linaro:master Apr 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants