updating readme to make it easier to deploy using docker #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for web-check ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lissy93
reviewed
Mar 19, 2024
| @@ -779,8 +779,16 @@ Click the button below, to deploy to Vercel 👇 | |||
|
|
|||
| ### Deploying - Option #3: Docker | |||
|
|
|||
| Pull Image: `docker pull lissy93/web-check` | |||
There was a problem hiding this comment.
Pull Image:
docker pull lissy93/web-check
I don't think this is necessary, as if the image isn't found locally, it'll be pulled automatically during the run command. The exception being, unless they user wants to use a different registry (like GHCR). But in this instance, running that pull command will just download it from DockerHub, same as in the run command.
| Run `docker run -p 3000:3000 lissy93/web-check`, then open [`localhost:3000`](http://localhost:3000) | ||
|
|
||
| or: | ||
|
|
||
| Run `docker -d --name webcheck -p 3000:3000 --restart=always lissy93/web-check`, then open [`localhost:3000`](http://localhost:3000) |
There was a problem hiding this comment.
+1 to this. Or maybe a docker-compose.yml would be more suitable, as that's what most people are going to use to deploy, and it gets a bit hard to read with many docker flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small edit to readme