Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci/create_release_pull_request): Fetch 5 extra commits #24532

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 14, 2024

Description

To avoid failing if base branch has moved.

Alternative to this (if we want to strictly require branches to be in sync) would be an error message that explains the situation.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@legobeat legobeat requested a review from danjm May 14, 2024 22:35
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat marked this pull request as ready for review May 14, 2024 22:37
@legobeat legobeat requested review from kumavis, brad-decker and a team as code owners May 14, 2024 22:37
@legobeat legobeat force-pushed the ci-fix-create-release-branch branch 2 times, most recently from 70947ad to 78234ab Compare May 21, 2024 00:16
@legobeat legobeat force-pushed the ci-fix-create-release-branch branch 2 times, most recently from de8a602 to 143d0ae Compare May 31, 2024 04:02
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.70%. Comparing base (d27a233) to head (71e9432).
Report is 220 commits behind head on develop.

Current head 71e9432 differs from pull request most recent head deb6533

Please upload reports for the commit deb6533 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24532      +/-   ##
===========================================
- Coverage    67.37%   65.70%   -1.67%     
===========================================
  Files         1278     1366      +88     
  Lines        49881    54361    +4480     
  Branches     12944    14141    +1197     
===========================================
+ Hits         33605    35714    +2109     
- Misses       16276    18647    +2371     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the ci-fix-create-release-branch branch 15 times, most recently from deb6533 to 9cfad9c Compare June 1, 2024 05:16
To avoid failing if base branch has moved
@legobeat legobeat force-pushed the ci-fix-create-release-branch branch from 9cfad9c to dfb147a Compare June 1, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

None yet

1 participant