-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetch nfts on components #24547
Open
sahar-fehri
wants to merge
19
commits into
develop
Choose a base branch
from
feat/refactor-nft-experience
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,020
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sahar-fehri
force-pushed
the
feat/refactor-nft-experience
branch
2 times, most recently
from
May 30, 2024 14:20
88a439f
to
5ca4a88
Compare
sahar-fehri
force-pushed
the
feat/refactor-nft-experience
branch
from
June 3, 2024 07:42
6afa84e
to
da18690
Compare
3 tasks
sahar-fehri
added
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
team-assets
labels
Jun 6, 2024
Builds ready [0383c5a]
Page Load Metrics (159 ± 228 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [0383c5a]
Page Load Metrics (159 ± 228 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
team-assets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to:
1- Enable nft autodetection by default
2- Show a modal only once if the user disables the nft autodetection
3- Make NFT detection tied to the components that use the NFTs instead of the 3mins polling strategy.
This PR goes with this core PR: MetaMask/core#4281
Related issues
Related to: MetaMask/core#4281
Manual testing steps
Test the nft auto detection modal
not right now
button should close the modal and closing onallow
button should enable the nft auto detection modal.Test the removal of the polling in the backgound:
We have the toggle enabled by default now but this should not trigger calls to NFT-API every 3 mins anymore.
Instead the calls should be triggered only when you click on the NFT tab.
(where the old logic should keep detecting your NFTs every 3 mins as long as you have MM open)
Screenshots/Recordings
Before
Screen.Recording.2024-06-06.at.21.57.21.mov
After
after.mov
Pre-merge author checklist
Pre-merge reviewer checklist