Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated mmi packages #24548

Merged
merged 17 commits into from
May 22, 2024
Merged

feat: updated mmi packages #24548

merged 17 commits into from
May 22, 2024

Conversation

albertolive
Copy link
Contributor

@albertolive albertolive commented May 15, 2024

Description

Updated MMI packges

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@albertolive albertolive added the team-mmi PRs from the MMI team label May 15, 2024
@albertolive albertolive requested a review from a team as a code owner May 15, 2024 18:48
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@albertolive
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@albertolive albertolive requested review from a team as code owners May 15, 2024 18:58
@albertolive albertolive requested a review from a team as a code owner May 16, 2024 07:33
@metamaskbot
Copy link
Collaborator

Builds ready [d4bebd7]
Page Load Metrics (763 ± 510 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint59159952411
domContentLoaded9321773
load5525937631062510
domInteractive9321773
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

zone-live
zone-live previously approved these changes May 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [6854a8b]
Page Load Metrics (661 ± 436 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint56137912110
domContentLoaded83817115
load452256661908436
domInteractive83817115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

# Conflicts:
#	app/scripts/controllers/mmi-controller.test.ts
#	package.json
#	yarn.lock
@albertolive
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

Copy link

socket-security bot commented May 21, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Shell access npm/detect-libc@1.0.3
Deprecated npm/npmlog@4.1.2
  • Reason: This package is no longer supported.
Deprecated npm/are-we-there-yet@1.1.7
  • Reason: This package is no longer supported.
Deprecated npm/gauge@2.7.4
  • Reason: This package is no longer supported.
Deprecated npm/osenv@0.1.5
  • Reason: This package is no longer supported.
Shell access npm/osenv@0.1.5
Deprecated npm/@npmcli/move-file@2.0.1
  • Reason: This functionality has been moved to @npmcli/fs
Deprecated npm/are-we-there-yet@3.0.1
  • Reason: This package is no longer supported.
New author npm/are-we-there-yet@3.0.1
Deprecated npm/gauge@4.0.4
  • Reason: This package is no longer supported.
Network access npm/needle@2.4.0
Network access npm/needle@2.4.0
Deprecated npm/node-pre-gyp@0.12.0
  • Reason: Please upgrade to @mapbox/node-pre-gyp: the non-scoped node-pre-gyp package is deprecated and only the @mapbox scoped package will recieve updates in the future
New author npm/node-pre-gyp@0.12.0

View full report↗︎

Next steps

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/detect-libc@1.0.3
  • @SocketSecurity ignore npm/npmlog@4.1.2
  • @SocketSecurity ignore npm/are-we-there-yet@1.1.7
  • @SocketSecurity ignore npm/gauge@2.7.4
  • @SocketSecurity ignore npm/osenv@0.1.5
  • @SocketSecurity ignore npm/@npmcli/move-file@2.0.1
  • @SocketSecurity ignore npm/are-we-there-yet@3.0.1
  • @SocketSecurity ignore npm/gauge@4.0.4
  • @SocketSecurity ignore npm/needle@2.4.0
  • @SocketSecurity ignore npm/node-pre-gyp@0.12.0

zone-live
zone-live previously approved these changes May 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [d97df1d]
Page Load Metrics (773 ± 516 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint66169972813
domContentLoaded95318136
load5326787731075516
domInteractive95318136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

DDDDDanica
DDDDDanica previously approved these changes May 21, 2024
@albertolive albertolive dismissed stale reviews from DDDDDanica and zone-live via 6e99a52 May 22, 2024 05:49
@albertolive
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

@metamaskbot
Copy link
Collaborator

Builds ready [caab360]
Page Load Metrics (1369 ± 568 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint714341227737
domContentLoaded10351584
load58280413691184568
domInteractive10351584
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live
Copy link
Contributor

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot
Copy link
Collaborator

Builds ready [510d049]
Page Load Metrics (913 ± 499 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint71147982612
domContentLoaded9401373
load5924579131040499
domInteractive9401373
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica DDDDDanica merged commit 2e369db into develop May 22, 2024
71 of 72 checks passed
@DDDDDanica DDDDDanica deleted the bump-mmi-packages branch May 22, 2024 10:58
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants