Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds the new default settings view to onboarding #24562

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented May 16, 2024

Description

Introduces the new Default Settings view and Congratulations views depending on the fact if user imported a wallet or created a new one.

User imported a wallet:
Screenshot 2024-06-03 at 16 08 44

User created a new wallet and backed up the seed phrase:
Screenshot 2024-06-03 at 16 11 13

User created a new wallet and didn’t back up the seed phrase:
Screenshot 2024-06-03 at 16 09 37

Inside look on the Default Settings:
Screenshot 2024-06-03 at 16 13 49
Screenshot 2024-06-03 at 16 14 00

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live changed the title [MMI] adds default settings view to onboarding feat: adds the new default settings view to onboarding May 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [a81133f]
Page Load Metrics (1002 ± 551 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6114092199
domContentLoaded9301463
load57256410021147551
domInteractive9301463
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.01 KiB (0.06%)
  • common: 647 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [cf34cc7]
Page Load Metrics (803 ± 539 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60193953115
domContentLoaded96416136
load4828258031122539
domInteractive96416136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.01 KiB (0.06%)
  • common: 647 Bytes (0.01%)

@zone-live zone-live marked this pull request as ready for review June 4, 2024 11:07
@zone-live zone-live requested a review from a team as a code owner June 4, 2024 11:07
@darkwing darkwing added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jun 4, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [eb245b7]
Page Load Metrics (102 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67997774
domContentLoaded812910
load401183102248119
domInteractive812910

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 12 lines in your changes missing coverage. Please review.

Project coverage is 65.74%. Comparing base (5d54e8b) to head (317f8e9).

Current head 317f8e9 differs from pull request most recent head 6e7b8e6

Please upload reports for the commit 6e7b8e6 to get more accurate results.

Files Patch % Lines
...boarding-flow/privacy-settings/privacy-settings.js 76.47% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24562      +/-   ##
===========================================
+ Coverage    65.67%   65.74%   +0.07%     
===========================================
  Files         1359     1369      +10     
  Lines        54015    54445     +430     
  Branches     14017    14184     +167     
===========================================
+ Hits         35469    35791     +322     
- Misses       18546    18654     +108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a few quick nits, overall looks great!

@metamaskbot
Copy link
Collaborator

Builds ready [317f8e9]
Page Load Metrics (154 ± 186 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7513298157
domContentLoaded9261442
load451843154388186
domInteractive9261442

@yanrong-chen
Copy link

Overall it looks great!
Design QA:

  1. When I click back button on the default settings page, it automatically ends the onboarding flow
  2. On "Assets" page, "Show incoming transactions" is not using the same text as other headers.
    Screenshot 2024-06-05 at 11 55 25 AM

Also, it will be great if we can:

  1. For "Your wallet is ready" screen, combine the sentences into 1 paragraph and highlight only "Learn more" (Sorry I might not have specified that earlier)
Wallet is ready 2. On default settings page, expand the touch area to be not just the title, but the entire cell Touch area

@metamaskbot
Copy link
Collaborator

Builds ready [6e7b8e6]
Page Load Metrics (129 ± 151 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63166892110
domContentLoaded8311263
load421494129313151
domInteractive8311263
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.9 KiB (0.07%)
  • common: 671 Bytes (0.01%)

@zone-live
Copy link
Contributor Author

zone-live commented Jun 6, 2024

@yanrong-chen I've updated the UI, and addressed the other points as well 👍🏼

Screenshot 2024-06-06 at 14 05 47

Screenshot 2024-06-06 at 14 06 27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-qa needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants