Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding delete metametrics data to security and privacy tab #24571

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

NiranjanaBinoy
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy commented May 17, 2024

This PR is dependant on #24503

Description

  • Added a new functional component as an entry to the Security & Privacy tab with the Delete MetaMetrics Data button.
  • A new Delete MetaMetrics Data model will open when you click the button.
  • Clicking the Clear button in the modal will create a data deletion regulation, update the state, and close the modal, deactivating the Delete MetaMetrics Data button.
  • The Erroring on the Clear button click opens a new error modal.

Scenarios to disable the DeleteMetaMetrics button:

  1. Metametrics ID not created / not available
  2. Just performed a deletion independent on participate in metametrics toggle
  3. Participate in metric opt-out & no data is recorded after deletion.
  4. Status of current delete regulation as INITIALIZED, RUNNING, or FINISHED and (Participate in metric opt-out/no data recorded after deletion)

Open in GitHub Codespaces

Related issues

Fixes #24406 #24407

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NiranjanaBinoy NiranjanaBinoy self-assigned this May 17, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

JustifyContent,
TextVariant,
} from '../../../helpers/constants/design-system';
import { createMetaMetricsDataDeletionTask } from '../../../store/actions';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this PR should stay in draft until the controller exists? As-is this is not mergable because this function does not exist.

@legobeat legobeat marked this pull request as draft May 23, 2024 00:11
@NiranjanaBinoy NiranjanaBinoy marked this pull request as ready for review June 1, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

Adding MetaMetrics data deletion to Security & Privacy
2 participants