Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Patch @metamask/key-tree #24572

Closed
wants to merge 4 commits into from
Closed

fix: Patch @metamask/key-tree #24572

wants to merge 4 commits into from
+173 −230

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented May 17, 2024 •
edited

Fixes Storybook failure by patching @metamask/key-tree.

This is merely an expedient to unblock #24550. The underlying issue will be addressed in the relevant packages.

@rekmarks rekmarks requested a review from a team as a code owner May 17, 2024 04:37
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 17, 2024
@legobeat
Copy link
Contributor

legobeat commented May 17, 2024 •
edited

Is there a reason why this is specific only for metamask-extension and not other users of the package? Or could we (also/instead) make a corresponding change upstream?

@rekmarks
Copy link
Member Author

rekmarks commented May 17, 2024 •
edited

@legobeat added context to description:

This is merely an expedient to unblock #24550. The underlying issue will be addressed in the relevant packages.

@FrederikBolding FrederikBolding requested review from a team as code owners May 21, 2024 17:05
Base automatically changed from fb/snaps-bump-v47 to develop May 21, 2024 21:20
@legobeat
Copy link
Contributor

legobeat commented May 21, 2024 •
edited

@rekmarks @FrederikBolding Is this still relevant after merge of #24550 and new version of @metamask/key-tree?

@rekmarks
Copy link
Member Author

@legobeat no!

@rekmarks rekmarks closed this May 22, 2024
@rekmarks rekmarks deleted the rekm/snaps-bump-v47-patch branch May 22, 2024 03:07
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rekmarks @legobeat @metamaskbot @FrederikBolding