GH-4966 Refactor the desktop entry #4971
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the desktop file icon lookup, to enable app icon theming. The Icon line uses the icon name instead of the full path. For this to work, the icon is moved to a directory specified by the standard (`/usr/share/icons/hicolor/scalable/apps/`). As the standard highly suggests, a 48x48 png icon is also added (rendered from the svg with inkscape). Added the `StartupWMClass` directive, so that window managers can associate the created windows with the desktop icon. Changed the rpm spec file to reflect the aforementioned changes. Fixes MultiMC#4966
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the desktop file icon lookup, to enable app icon theming. The Icon line uses the icon name instead of the full path. For this to work, the icon is moved to a directory specified by the standard (
/usr/share/icons/hicolor/scalable/apps/). As the standard highly suggests, a 48x48 png icon is also added (rendered from the svg with inkscape).Added the
StartupWMClassdirective, so that window managers can associate the created windows with the desktop icon.Changed the rpm spec file to reflect the aforementioned changes.
Fixes #4966