Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations aren't working with the latest release of Metaflow #1515

Closed
tylerpotts opened this issue Aug 29, 2023 · 0 comments · May be fixed by #1568
Closed

Annotations aren't working with the latest release of Metaflow #1515

tylerpotts opened this issue Aug 29, 2023 · 0 comments · May be fixed by #1568

Comments

@tylerpotts
Copy link
Contributor

This issue was introduced in #1442

When running a flow on kubernetes with a project tag, the project tag annotation is not added. Additionally the user and flow_name annotations are absent

Using this basic flow on the latest version of metaflow:

from metaflow import FlowSpec, IncludeFile, conda_base, kubernetes, retry, step, project, catch, Parameter, Flow

dependencies = {
    "pip": "23.0.1",
}
@project(name='tyler_test')
@conda_base(libraries=dependencies, python='3.10.10')
class TylerMissingAnnotations(FlowSpec):



    @retry
    @kubernetes(cpu=1, memory=4000)
    @step
    def start(self):
        self.next(self.end)

    @step
    def end(self):
        print('Done')


if __name__ == '__main__':
    TylerMissingAnnotations()

Viewing the annotations shows the project tag is missing and the user/flow_name values are absent

 Annotations:          kubernetes.io/limit-ranger: LimitRanger plugin set: cpu, memory limit for container start                                                                                                                                                                        
                       metaflow/attempt: 0                                                                                                                                                                                                                                              
                       metaflow/flow_name:                                                                                                                                                                                                                                              
                       metaflow/run_id: 15646                                                                                                                                                                                                                                           
                       metaflow/step_name: start                                                                                                                                                                                                                                       
                       metaflow/task_id: 116765                                                                                                                                                                                                                                         
                       metaflow/user:                                                                                                                                                                                                                                                   
 Status:               Running         
@saikonen saikonen linked a pull request Oct 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant