feature: custom annotations revisited #1568
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikonen
force-pushed
the
feature/custom-annotations-fixed
branch
from
734de96
to
b9ce0f2
Compare
|
@saikonen Took this for a spin and everything is working as expected! |
saikonen
force-pushed
the
feature/custom-annotations-fixed
branch
from
b9ce0f2
to
8464b54
Compare
saikonen
commented
Oct 13, 2023
Comment on lines
+333
to
+354
| if self.parameters: | ||
| annotations.update({"metaflow/parameters": json.dumps(self.parameters)}) | ||
|
|
There was a problem hiding this comment.
Moved the new convenience annotations to this helper as well. One thing to note though is that this applies all of them to the generic self.kubernetes_annotations, which is applied generously as a baseline set of annotations (including for Sensors)
Do these annotations make sense for all objects, or should they be kept out of this helper? This simplifies the setup somewhat at least.
There was a problem hiding this comment.
@savingoyal Do you have an opinion on this?
saikonen
force-pushed
the
feature/custom-annotations-fixed
branch
from
8464b54
to
d4a2936
Compare
saikonen
force-pushed
the
feature/custom-annotations-fixed
branch
from
d4a2936
to
e6ab77c
Compare
|
Testing[678] @ 6257d47 |
|
Testing[678] @ 6257d47 had 3 FAILUREs. |
saikonen
force-pushed
the
feature/custom-annotations-fixed
branch
from
6257d47
to
617ead4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reintroduces the feature first merged in #1442 which had to be reverted in #1516 due to a regression that broke annotations for recording user and project info.
This feature keeps the 'system annotations' outside of the decorator scope, as in many cases the
currentsingleton is not initialized to its full extent.Also reintroduces the ability to set custom Kubernetes labels via the decorator, instead of only the environment variable.