Use mkstemp to replace deprecated mktemp #1836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace tempfile.mktemp() with tempfile.mkstemp() for enhanced security
savingoyal
requested changes
May 21, 2024
| @@ -405,7 +405,8 @@ def _tempfilepager(generator, cmd, color): | |||
| """Page through text by invoking a program on a temporary file.""" | |||
| import tempfile | |||
|
|
|||
| filename = tempfile.mktemp() | |||
There was a problem hiding this comment.
@fatmo666 this file is vendored as is from click. to fix this, you would need to update the vendored version for click.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request addresses a security concern related to the use of the deprecated tempfile.mktemp() function, which is known to be insecure due to its susceptibility to race conditions that can lead to temporary file vulnerabilities, as described in CWE-377.
Changes Made