-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHubCI: no need to filter by branch #1019
Conversation
Removing the branch filters from the GitHub workflows allows potential contributors to see the CI status of their contributions before they propose a PR (therefore allowing them to improve their work before putting it up for review).
@knocte Hola!!, this is going to need a different nuget build (output to a different number) with an autogenerated version number that is also mark AS something like 4.20.2323232.devbuild-securityrisk. I truly don't want unsigned nugets flying around that would allow people to tamper / build them and will allow them to put malicious code, I was already concerned about those unity builds.. Please let me know what you are trying to contribute! |
BTW, remember the Nethereum full package, it is already in Nethereum.FX for most of the packages, there are many users getting confused with this, again a security issue, people don't read the readme and realise that is a CI dev build, so if you can transfer the ownsership will be great and I do something about that.. although that is good for anyone not using the other extended libraries. |
This PR is not related to nuget package generation, it's about just dotnet build (because we're talking about GitHubCI here, not AzureDevops).
Ah cool, will try that package and if it works for us, then we can rename it to just 'Nethereum'. |
@knocte |
But nuget.bat is not pushing a nuget package to nuget.org. |
Yes but either way it is not a "valid" build it is a dev build.. I have changed it now .. I am seeing dlls flying around, imagine nugets too (people will get hacked..). It looks like this now.. also easier versioning with the suffix 317877f |
Ahhh I actually got you now, you just want to trigger the nuget build as a way of testing the build works.. as opposed to publish it or keep a copy of it in a branch (which is the step it was missing and was going to add... :) ) |
Note on this.. if ever wanted to commit the nugets to the devbuild folder use "skip ci" in the commit message, and commit the changes after build |
Removing the branch filters from the GitHub workflows allows potential contributors to see the CI status of their contributions before they propose a PR (therefore allowing them to improve their work before putting it up for review).