WebSocketClient, fixed starvation condition #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snake-4
added a commit
to snake-4/Nethereum
that referenced
this pull request
Nov 20, 2021
made StopAsync and StartAsync thread-safe. Implemented the fix for Nethereum#738. Fixed the problem where the _listener task completed immediately. The listener now quits when the WebSocket disconnects.
snake-4
added a commit
to snake-4/Nethereum
that referenced
this pull request
Nov 20, 2021
made StopAsync and StartAsync thread-safe. Implemented the fix for Nethereum#738. Fixed the problem where the _listener task completed immediately. Also, the listener now quits when the WebSocket disconnects.
snake-4
added a commit
to snake-4/Nethereum
that referenced
this pull request
Nov 20, 2021
made StopAsync and StartAsync thread-safe. Implemented the fix for Nethereum#738. Fixed the problem where the _listener task completed immediately. Also, the listener now quits when the WebSocket disconnects.
|
As per other threads.. (and new people coming over) I did not see any mayor improvements but keeping it open, in case it helps others. |
|
管理员在吗 快点把这个pr合并了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If method "HandleIncomingMessagesAsync()" is called before the websocket client is connected, the while() loop will get stuck in starvation condition, making continuous comparison without any CPU pause. This won't allow "_clientWebSocket" to connect, because CPU is stuck in that method, not allowing any other tasks to continue.
I propose initializing the listener when "_clientWebSocket" is already connected. May I propose other solutions, with an AutoResetEvent variable setted when a request is added to "_requests", if you do not like to initialize the listener at this point.
Starvation condition is tested and triggered in Ubuntu 21.04 (and I suppose it is happening in another OS). When "StreamingWebSocketClient" is instantiated in any project, the program will be stuck by 100% CPU usage.